What changes did you make? (Give an overview)
The typescript linter (ts-standard) needs to find the configuration file (tsconfig.json or tsconfig.eslint.json) in order to work. It searches, starting from the current working directory. When running the e2e test script and, I suspect, starting VSCode from a Linux shell, the CWD is set correctly and everything works. However this is not guaranteed - for example running from the Windows start menu has the CWD set to the installation directory.
The commit c4d3763d7e5d2e8b723b703cf403aea726e91c9c temporarily changes to the workspace folder before loading the typescript engine and restores the previous value afterwards. The workspace folder seems to be the correct one, at least for single workspace projects.
As mentioned the test code coincidentally sets the CWD correctly so this error never appears when running npm test. Commit 663b6fbef57fd923a2e971fdb8ebea743ffbc338 changes to a different directory (actually the temporary directory) prior to starting each test run which causes the ts-standard test to fail without the fix also being applied.
Which issue (if any) does this pull request address?
483
Is there anything you'd like reviewers to focus on?
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [X] Bug fix [ ] New feature [ ] Other, please explain:
What changes did you make? (Give an overview) The typescript linter (
ts-standard
) needs to find the configuration file (tsconfig.json
ortsconfig.eslint.json
) in order to work. It searches, starting from the current working directory. When running the e2e test script and, I suspect, starting VSCode from a Linux shell, the CWD is set correctly and everything works. However this is not guaranteed - for example running from the Windows start menu has the CWD set to the installation directory.The commit c4d3763d7e5d2e8b723b703cf403aea726e91c9c temporarily changes to the workspace folder before loading the typescript engine and restores the previous value afterwards. The workspace folder seems to be the correct one, at least for single workspace projects.
As mentioned the test code coincidentally sets the CWD correctly so this error never appears when running
npm test
. Commit 663b6fbef57fd923a2e971fdb8ebea743ffbc338 changes to a different directory (actually the temporary directory) prior to starting each test run which causes thets-standard
test to fail without the fix also being applied.Which issue (if any) does this pull request address?
483
Is there anything you'd like reviewers to focus on?