standardebooks / manual

The source code for the Standard Ebooks Manual of Style.
https://standardebooks.org/manual
Other
131 stars 33 forks source link

Switch signatures to use breaks before them #166

Closed vr8hub closed 1 month ago

vr8hub commented 1 month ago

Change our examples to reflect that signatures should be preceded by <br/>, not their own <p>. I went back and forth on whether the "eoc" was still correct on the "Yours, etc." before the Gardner signature. I left it, but maybe it should go?

vr8hub commented 1 month ago

We should still specifically mention this somewhere, but this at least gives them an example to follow.

acabal commented 1 month ago

Whether or not eoc (end of clause) belongs there also decides whether we put <br/> there. If Yours, et cetera. is a full clause, then we keep eoc and don't use <br/>. But if it's not a full clause, then we remove eoc and use <br/>. Right now I would say it's ambiguous. If there were a comma after etc., then it would unambiguously be the latter case. But if I had to pick, I would say that it's not a full clause, so we should remove eoc and keep <br/>.

vr8hub commented 1 month ago

Yeah, I agree, I don't think it's a full clause, either. The "etc." could be "truly" or "sincerely" or whatever, but it would still be an incomplete clause when all was said and done. I removed the eoc.

acabal commented 1 month ago

Thanks!