search

standardebooks / tools

The Standard Ebooks toolset for producing our ebook files.
Other
1.42k stars 125 forks source link

Is pyopenssl still required? #492

Closed robinwhittleton closed 2 years ago

robinwhittleton commented 2 years ago

https://github.com/standardebooks/tools/blob/dfda3927b7745ca0f501ea5862d6e13eba45d9fe/setup.py#L73

I just tried removing it and reinstalling the standardebooks local package, and create-draft happily pulls down a file from HTTPS Gutenberg with no problem. Was this just a historical need?

robinwhittleton commented 2 years ago

Oh, potentially this is just in the latest version: https://pyup.io/changelogs/requests/#2.26.0

The requests[security] extra has been converted to a no-op install. PyOpenSSL is no longer the recommended secure option for Requests. (5867)

acabal commented 2 years ago

In setup.py it says pyopenssl is "Required to allow the requests package to use https on Mac OSX". If that's not true anymore than we can delete it.