search

standardebooks / tools

The Standard Ebooks toolset for producing our ebook files.
Other
1.43k stars 127 forks source link

y-025 #693

Closed vr8hub closed 6 months ago

vr8hub commented 6 months ago

y-025 looks for a letter, a comma, any of the four quote marks, and another letter, with this regex: [a-z],[“”‘’][a-z] (case insensitive). y-012 looks for a rdquo followed immediately by a letter: ”[A-Za-z]

Thus, checking for a rdquo in y-025 is redundant. It's not redundant the other way, because y-012 doesn't look for a letter prior to the rdquo, while y-025 does. Thus y-012 is going to catch anything y-025 does (for the rdquo), but the reverse is not true.

IOW, we can drop the rdquo from y-025.

acabal commented 6 months ago

OK, but add a comment explaining that so if we see it again in the future we'll know why we only included 3/4 of the quotation marks.