search

standardebooks / web

The source code for the Standard Ebooks website.
https://standardebooks.org
Creative Commons Zero v1.0 Universal
235 stars 64 forks source link

Donation request overlays and obscures content on kindle browser #204

Closed michaelkirk closed 1 year ago

michaelkirk commented 1 year ago

When trying to download an ebook directly to my kindle, using the built in browser, a donation overlay that I cannot dismiss appears on the book pages (e.g. https://standardebooks.org/ebooks/anthony-trollope/phineas-finn), obscuring the content.

(sorry for the terrible screenshot) kindle_popup

I assumed the pop-up was intentional (albeit annoying) and tried to dismiss it, but I couldn't figure out how. I was able to scroll past the obscured content to get to the download section (see video). So, provided you aren't interested in reading the description, it's not a huge deal.

https://user-images.githubusercontent.com/217057/204357141-30cc48a8-4777-477c-b7d5-cf52572bd25c.mp4

I had originally assumed this was an issue with an errant "pop-up" that you should be able to dismiss, but on desktop (macos safari) and mobile browsers (iOS) this donation request appears in line, and not as an overlay, which seems preferable anyway. So maybe this is actually a layout incompatibility with kindle's browser. 🤷

Firmware Version: Kindle 5.12.4

acabal commented 1 year ago

The donation box is structured as <aside>, it's not meant to be a popup. Perhaps Kindle things that it's an endnote or something?

I set the website to serve <div> to the Kindle browser, so maybe that will fix it. If not then this is definitely a Kindle browser bug and you should report it to them.