search

standardese / cppast

Library to parse and work with the C++ AST
Other
1.7k stars 164 forks source link

Fixed files with backslashes not reporting any items #139

Closed MetalSlime0 closed 2 years ago

MetalSlime0 commented 2 years ago

parse_linemarker was turning double backslashes into quadruple backslashes. Making it instead turn them into single backslashes makes the "lm.value().file == path" comparison true in preprocess() so that p.enable_write() is called.

fixes foonathan/cppast#106

MetalSlime0 commented 2 years ago

I didn't intend for my second commit to be part of the same pull request. Sorry, new to this.

foonathan commented 2 years ago

I didn't intend for my second commit to be part of the same pull request. Sorry, new to this.

Thank you, and no problem. When you implement my feedback, please amend and force push so there are two commits: one for the backslashes and one for the intrusive list. I can then rebase.

foonathan commented 2 years ago

I've manually adapted it and merged it. Thanks!