search

standardhealth / ballot

0 stars 0 forks source link

"shr-" prefixes still exist in the IG #35

Closed okeefm closed 6 years ago

okeefm commented 6 years ago

URLs for types defined in this ballot still contain the shr- prefix: http://build.fhir.org/ig/HL7/us-breastcancer/StructureDefinition-oncology-BreastCancerHistologicGrade-model-definitions.html contains several examples:

Others include:

Should these be prefixed with the shr- prefix? Or should that be removed in favor of something like oncology-, as has been done for other types?

Also, there are many types that still contain the cimi- prefix, such as http://build.fhir.org/ig/HL7/us-breastcancer/StructureDefinition-cimi-statement-Members-model.html . Should those prefixes be there as well?

cmoesel commented 6 years ago

Those prefixes reflect the namespaces from which the elements came. I think they need to stay.

okeefm commented 6 years ago

If so, that's fine. I just wanted to ensure these don't need to go away as a result of the "debranding" I'm supposed to be doing.

cmoesel commented 6 years ago

Since @markkramerus asked you to do the debranding, feel free to run it by him. But I'm not sure how we easily get around this one without instituting some special case code that would have to be turned off when we generate an SHR IG.

markkramerus commented 6 years ago

It's minimized, but the datatypes are all shr types. So that's why you see it. Thanks for checking. Might as well have a little something in there with SHR :-)