search

standardnotes / filesafe-relay

Relay server used to communicate between FileSafe client extension and server destination (Dropbox, Google Drive, WebDAV)
14 stars 9 forks source link

Add support for S3 compatible endpoints #32

Closed pho closed 3 years ago

pho commented 3 years ago

This PR adds a provider selector on the S3 form image Since this is generic S3 now, I removed some AWS references in the code, but had to keep the integration name to avoid breaking current users' setup

I tested this against Scaleway Object Storage and its working nice. This should close #10 too

I do not have an AWS nor B2 account, so I haven't been able to test those!

moughxyz commented 3 years ago

Thanks for the PR 👌 I have this marked as unread in my inbox, so I'll get to it, but can't say precisely when.

curiousleo commented 3 years ago

I went looking for the repo precisely to find out if S3-compatible storage is supported (rather than just AWS), and this is the most recently merged PR -- nice.

It looks like there has not been a release since this was merged on 12 Feb, although I'm not sure. I just installed the FileSafe extension and in Standard Notes it says I'm on version 2.0.10 of FileSafe. The releases page lists 1.2.12 as the most recent version, released on 13 Nov 2020.

So basically: this is a feature that I really want to use, and I'd love to see a version of FileSafe with this PR being released so I can start attaching documents to my notes :)

JaspalSuri commented 3 years ago

The change had to be reverted because it broke existing S3 integrations (for users using Amazon's S3 buckets). We would be interested in accepting (and testing) a potential fix for that issue. 🙂

That said, we are looking to replace FileSafe in the future by providing a first-party hosting solution for files.