standardnotes / forum

Support from other community members. For 1-on-1 help, please contact help@standardnotes.com.
https://forum.standardnotes.org
199 stars 8 forks source link

Sync Status Display Stuck - Pale Moon #1917

Closed adisib closed 2 years ago

adisib commented 4 years ago

In the Pale Moon web browser, the Sync Status display in the account pop-up tab seems to be unable to update. Syncing the data seems to work correctly, and this seems to be an issue only with the update of the display. This behavior occurs elsewhere as well, such as "Generating Account Keys" in the same account tab not progressing when creating a new account.

I was told this issue can also manifest in Firefox, which Pale Moon has derived from, and am opening this issue as requested.

The issue seems likely to be related to a javascript error preventing any update code from executing. Every click on the page gives a "ReferenceError: event is not defined" message in the console.

standardnoteserror

The referenced line 23:11826 seems to be the following: i.bind("click",function(){event.target.closest(".sk-modal")||r||(e.$apply(n.clickOutside),r=!0)}) This appears to be the deprecated JQuery .bind() function which is trying to reference the eventData argument even though it wasn't passed in the function parameters.

Edit: A quick glance at your code base shows that the referenced line is likely to be lines 16-26 of "click-outside.js" ( https://github.com/standardnotes/web/blob/master/app/assets/javascripts/directives/functional/click-outside.js ).

I hope this issue can be resolved, as it is the only issue I have encountered in Pale Moon so far. I hope that Pale Moon can be officially supported.

adisib commented 4 years ago

Actually, the javascript error is probably unrelated, as it doesn't occur when clicking on the account button, but only when clicking on anything else (unless I right click, which triggers it on the account button as well). Sorry for not testing more thoroughly.

JaspalSuri commented 4 years ago

I can reproduce this on Windows 10. I think Pale Moon and Firefox are different enough to where issues like this can come up. I'll discuss this issue with the team.

ghost commented 4 years ago

Do you want help drafting official support for the browser?

JaspalSuri commented 4 years ago

I created a post on Pale Moon's forum a received a response a kind response the dev. Currently it seems that Pale Moon might not work with Standard Notes for some fundamental technical reasons that aren't an issue with other web browsers (this isn't meant as a slight to them, of course!) and we'll have to consider the scope of what might be required of the suggestions made by Pale Moon's developer.

Do you want help drafting official support for the browser?

That's greatly appreciated, but I would suggest putting it on hold until the refactor is completed when version 3.5 of the apps ship. We also want to respect your time and hard work; it's also possible that the PR might not be accepted due to other technical reasons (a mistake I acknowledge having made before with another user).

ghost commented 4 years ago

Sounds good :)

affe42 commented 4 years ago

Seems to be working ok with web app v3.5.0.beta9 and Pale Moon v28.14.2.

JaspalSuri commented 4 years ago

Thanks (again) for providing the update here! I was just about to do that. đŸ™‚