Closed christianhans closed 5 years ago
Do you know if Firefox provides an API for different icon shades?
Not sure, but I might it be a solution to make this icon non-transparent? Whatever Icon is used when adding a Shortcut in Chrome is non-transparent and that works great:
It seems like many Favicons on the Web are transparent and Firefox is well aware of the issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1094357
So perhaps keeping the transparency is fine and it is more of a Firefox issue at this point. In the future there will be a new CSS property to detect color schemes (only Safari has it for now): https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
Got it, thanks. We can make the background transparent. Although the foreground will still be black and difficult to see. Do you have examples of how other websites with black foreground icons look with dark mode?
Here is GitHub in comparison to StandardNotes:
I really like the Standard Notes icon used on Twitter. Why not use that as FavIcon? Looks a lot better imho.
https://pbs.twimg.com/profile_images/865015980518502404/9j4C27ZH_400x400.jpg
That's kind of what we use, just not filled in. Might be too distracting. I'll give it a shot though next time I'm updating this section of the app.
Adjusted in latest release.
Firefox's dark mode uses a black background for tabs on macOS. This make the Standard Notes Icon very hard to identify, especially with Pinned Tabs:
https://user.fm/files/v2-605062a2fe903c70897b20ccf17e7f60/Screen%20Shot%202018-12-11%20at%205.07.34%20PM.png