standardnotes / forum

Support from other community members. For 1-on-1 help, please contact help@standardnotes.com.
https://forum.standardnotes.org
196 stars 9 forks source link

RTL Padding/margin are off and incorrect for super notes #3262

Closed eadoking closed 1 year ago

eadoking commented 1 year ago

related to issue #3261, where I explained the reproduction in details for the list/sublists

In addition to what it was in that issue, after a detailed check, all the elements which has margin-left or padding-left need to be corrected to have the theme work as expected

The following elements are affected

I think most of the changes could be done in this file https://github.com/standardnotes/app/blob/main/packages/web/src/javascripts/Components/SuperEditor/Lexical/Theme/editor.scss

effieeee commented 1 year ago

Please see this comment with the link to the fix!

eadoking commented 1 year ago

Hi @effieeee, I saw the comment. This fixes only the lists, (ol/ul/li) but also need to fix the

image

the quotes in Arabic or RTL / should also be margined from right for this to be fixed + border + padding

so after these changes

image

(color should come from theme)

we get the correct display as

image

@amanharwara please check this comment Please reopen the issue #3262

amanharwara commented 1 year ago

Hi @eadoking, thanks for letting us know, I'll push a fix soon. Also, there's no need to comment about the same thing in multiple places. Once would've sufficed, thanks 🙂

eadoking commented 1 year ago

Hi @eadoking, thanks for letting us know, I'll push a fix soon. Also, there's no need to comment about the same thing in multiple places. Once would've sufficed, thanks 🙂

Thanks ❤️