search

standardnotes / markdown-basic

[Moved to https://github.com/standardnotes/app] A basic Markdown editor for Standard Notes
https://standardnotes.com
GNU Affero General Public License v3.0
11 stars 12 forks source link

fix: improve code highlighting #16

Closed dagjaneiro closed 5 years ago

dagjaneiro commented 5 years ago

I've tackled this issue by replacing the markdown-it-highlight package with the markdown_it_highlightjs package that serves the same purpose but behaves correctly for the issues reported.

It also seems to be the prefered package for this functionality in npm if we take into account the number of weekly downloads.

To avoid any change in styling I'm applying the same theme used internally by the old package: atom-one-light.

Example before fix: sh_before

Example after fix: sh_after

I've also removed the yarn.lock file since you seem to be using npm as the package manager.

Closes standardnotes/bounties#17

moughxyz commented 5 years ago

Nice work! The auto language detect is really cool.