search

standardnotes / markdown-basic

[Moved to https://github.com/standardnotes/app] A basic Markdown editor for Standard Notes
https://standardnotes.com
GNU Affero General Public License v3.0
11 stars 12 forks source link

Enable Spellcheck in Desktop App #19

Closed christianhans closed 4 years ago

christianhans commented 5 years ago

On iOS the Edit view supports spell check. Is it possible to enable Spell check in the Desktop app as well? After all the Edit view is probably just a simple TextArea?

moughxyz commented 5 years ago

I haven't found a way for Electron to enable spellcheck in an iframe.

christianhans commented 5 years ago

Does this help?

https://github.com/electron/electron/issues/13514

moughxyz commented 5 years ago

Oo nice find! I was able to get that working for some of the editors, but not all of them. The two that didn't work were Advanced MD and Minimal MD. I'll have to play around with this a little more.

christianhans commented 5 years ago

Those don’t seem to support Spellcheck on iOS either.

moughxyz commented 5 years ago

Oh it might be CodeMirror based editors actually. Usually those behave in tandem.

christianhans commented 5 years ago

It seems like EasyMDE behind the Advanced Markdown Editor supports spell check according to its documentation. Can extensions check whether spell check in Standard Notes is enabled globally and then toggle Spellcheck within their component?

moughxyz commented 5 years ago

It does support its own spellcheck, but last we had this enabled it was a real troublemaker. I wish I remember what the exact reason was. But it might be worth revisiting.

TheodoreChu commented 4 years ago

I think as of v3.4, spellcheck for Markdown Basic is available on all platforms, but we can add spellcheck=true to the <textarea>