search

standardnotes / markdown-basic

[Moved to https://github.com/standardnotes/app] A basic Markdown editor for Standard Notes
https://standardnotes.com
GNU Affero General Public License v3.0
11 stars 12 forks source link

line-height issue #3

Open ghost opened 6 years ago

ghost commented 6 years ago

The lack of declaration of line-height for #editor makes text really really hard to read. It should have been 1.2em at least. You can try to play with the value to see what I mean. It gives the text air to breath, right now it personally causes me headache because it's way too concentrated.

moughxyz commented 6 years ago

Hmm maybe. In any case, custom changes like this aren't the best long term solution. Best to build solutions that instead allow everyone to get what they want. A custom theme builder in the future would be a better solution.

ghost commented 6 years ago

@mobitar I think this is a detail that will make usability better for everyone, it's not a major overhaul that would better wait for the proper framework to be handled...

moughxyz commented 6 years ago

Feel free to submit a PR, I don't think I'll get a chance to visit this repo any time soon.

TheodoreChu commented 4 years ago

The <textarea> in #editor-container doesn't inherit the line-height of #simple-markdown. I'll fix this in the TypeScript conversion. I think 1.5em is the minimum for accessibility according to W3: https://www.w3.org/TR/2008/REC-WCAG20-20081211/#visual-audio-contrast-visual-presentation