search

standardnotes / markdown-pro

[Moved to https://github.com/standardnotes/app] Markdown Pro editor for Standard Notes (formerly Advanced Markdown Editor)
GNU Affero General Public License v3.0
31 stars 21 forks source link

macos markdown preview code block issues #40

Closed blissend closed 4 years ago

blissend commented 4 years ago

The editor called Markdown Pro in preview mode has a display issue with code blocks. For really long lines it doesn't extend the visual block all the way horizontally as shown here... https://imgur.com/a/AvW7KN5.

The same editor on the last line in preview mode, inline code blocks cuts off letters like g and y of the line above as shown here... https://imgur.com/a/QKABIAK

Let me know if you need any more information.

blissend commented 4 years ago

Just realized this is derived from https://github.com/Ionaru/easy-markdown-editor and you have extensions over at https://github.com/sn-extensions but couldn't find one for pro, only the basic editor. Is markdown pro still supported or should we be just using markdown basic? If it's of any help the example editor this is derived from (https://easymde.tk/) doesn't seem to replicate either issue above.

arielsvg commented 4 years ago

Hey @blissend! If there is a bug in our implementation of a derived editor we generally want to fix it. The editor's repo is currently located at https://github.com/standardnotes/advanced-markdown-editor, sorry for making you look! I'm transferring your issue there. And thanks for supporting us with Extended 😊

joshcsullivan commented 4 years ago

Related: https://github.com/standardnotes/forum/issues/1008#issue-635614874

When running SN from PS and opening a note in the Markdown Pro editor, I see this:

PackageManager: Extracting C:\Users\USERNAME~1\AppData\Local\Temp\Standard Notes\downloads\Markdown Pro.zip to C:\Users\USERNAME\AppData\Roaming\Standard Notes\Extensions\org.standardnotes.advanced-markdown-editor
(node:9832) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(node:9832) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
PackageManager: Installed component Markdown Pro
PackageManager: received sync event for: Markdown Pro (1.3.7) (deleted: false)
PackageManager: received sync event for: Markdown Pro (1.3.7) (deleted: false)
Uncaught exception SyntaxError: Unexpected token < in JSON at position 0
    at JSON.parse (<anonymous>)
    at IncomingMessage.<anonymous> (C:\Users\USERNAME\AppData\Local\Programs\standard-notes\resources\app.asar\dist\index.js:22:255307)
    at IncomingMessage.emit (events.js:210:5)
    at endReadableNT (_stream_readable.js:1183:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

OS: Windows 1909 Enterprise SN: 3.4.2-beta1 Markdown Pro: 1.3.7

ningsongshen commented 4 years ago

@joshcsullivan the code block issue should be fixed now. Thanks for using Standard Notes!