search

standardnotes / minimal-markdown-editor

[Moved to https://github.com/standardnotes/app]
GNU Affero General Public License v3.0
10 stars 15 forks source link

fix: mobile selected text turned off on codemirror #17

Closed bryvin closed 5 years ago

bryvin commented 5 years ago

Turns off CodeMirror's own selected text highlight that made mobile text selection impossible to see the text you actually had selected.

This is in line with the Advanced Markdown Editor now.

moughxyz commented 5 years ago

We actually have mobile detection built into components-api: https://github.com/sn-extensions/components-api/blob/master/src/componentManager.js#L110

bryvin commented 5 years ago

Ahh of course, will update this soon

bryvin commented 5 years ago

Updated this to use the componentManager isMobile variable over a custom implementation in this editor. Also updated deps while I was at it.