search

standardnotes / minimal-markdown-editor

[Moved to https://github.com/standardnotes/app]
GNU Affero General Public License v3.0
10 stars 15 forks source link

Sublists still render green #30

Closed christianhans closed 4 years ago

christianhans commented 4 years ago
Screen Shot 2020-07-25 at 3 18 08 PM
JaspalSuri commented 4 years ago

Hi, Christain. Thanks for letting us know! I was able to reproduce this as well and will make sure the team's aware of this issue.

MorgothSauron commented 4 years ago

Is this really a bug ? Because it's been like this since I started to use SN and this is my default editor.

image

I think the current color scheme for this editor is just fine and doe not need to be changed.

moughxyz commented 4 years ago

We were able to get level one list items changed to default text color, but as anticipated, that CSS selector (cm-variable-2) is shared by code blocks, so those lost their blue tint. There still does not appear to be a way to differentiate list items from regular CodeMirror elements, so I still don't see a way to stylize nested list items with a more neutral text color.

ningsongshen commented 4 years ago

I just checked the code earlier and code blocks user a different selector: cm-comment. It might be possible to fix the indented list items, but I'll need to check on the side effects.

MorgothSauron commented 4 years ago

@mobitar @JaspalSuri Do you know why this is being changed ? I consider the current colors as a feature of the editor. It's been like this as far as I can remember. Minimal markdown is my main editor and using only black text for list will screw up the "look & feel" of this editor.