search

standardnotes / plus-editor

[Moved to https://github.com/standardnotes/app] The Plus Editor is a Standard Notes derived editor that is perfect for crafting any document.
GNU Affero General Public License v3.0
6 stars 12 forks source link

Fix cursor colour in code view #35

Closed ningsongshen closed 4 years ago

ningsongshen commented 4 years ago

Fixes the second issue here: https://app.asana.com/0/1178618677234188/1174395765556557/f

moughxyz commented 4 years ago

I would first make a PR addressing any code formatting improvements that doesn't impact functionality/UI at all. Then make a separate PR with just the UI change. This way, the two remain independent. We can revert one or the other without having to revert both. For example if something goes wrong with this cursor change, we would want to undo it, without losing all the formatting improvements we made. Also, it's very hard to see what exactly changed in this PR.

moughxyz commented 4 years ago

You know what, sorry, just saw your other PR :) I believe you did just that. Will review that first.

moughxyz commented 4 years ago

Ok please pull master into here and I think that should help.

ningsongshen commented 4 years ago

Oops I think it may have been a bit unclear because I created this branch off of clean-code so the commits are here too. I'll add a comment next time.

ningsongshen commented 4 years ago

Merged master :+1:

Explanation for fix: The code view background is always black, no matter the theme, so a light-coloured cursor is ideal.

moughxyz commented 4 years ago

Looks good. I suppose the real solution would be to eventually just theme the code view with StyleKit. But this is a good start.