Closed alpha-tango-kilo closed 1 year ago
I've updated the PR to cover the latest changes and remove conflicts. Can this please be reviewed/merged? @moughxyz @karolsojko
What's the reasoning behind the removal ?
It simplifies the configuration. On the contrary, why have it? It's 24 extra lines that don't (to my knowledge) have a practical impact on the program
They do create a network isolation layer from your default host network which actually serves as a so to say protection from other services and private communication layer between the services.
EDIT: The purpose of that network is to have a tangible name that we can adress if needed on a host. Otheriwse the name of the network is based on the directory your project resides in, which we cannot determine if needed.
They do create a network isolation layer from your default host network which actually serves as a so to say protection from other services and private communication layer between the services.
The default network still does this, to my understanding
The purpose of that network is to have a tangible name that we can address if needed on a host. Otheriwse the name of the network is based on the directory your project resides in, which we cannot determine if needed
This is a fair point. You could argue that there is no point having it declared until it's needed, but since it's already there, no need to take it out when you might end up reverting down the line
The same network was used by every container, so there's no reason why they couldn't just use the default one that Docker Compose sets up itself
I've been running this in my personal configuration and haven't noticed any issues, though I wouldn't consider myself a Standard Notes power user by any means. Not sure if there are any proper tests or such to ensure no functionality is lost