search

standupmaths / xmastree2021

Code and coordinates for Matt's 2021 xmas tree
MIT License
129 stars 58 forks source link

Twinkle and Bounce Animations #74

Open philipvr opened 2 years ago

philipvr commented 2 years ago

Created a white twinkle animation (@philipvr) and a red-green-blue bounce animation (@ghendley).

d-albrecht commented 2 years ago

I might be wrong, but I think I remember Matt saying last year that the lights appear brighter in real life than on stream. Taking this information into account, I'm not sure how the twinkle will look like on the real tree with all the "off-lights" being relatively bright. I would rather choose either to turn them off completely, or at least use a darker gray. But that's a general problem that I don't understand/know why some decide to use a default state (that isn't completely black) for LEDs that aren't part of the active pattern. For a simulator (with a black background) I can see the reasoning, for a submission I don't get it. In particular for the twinkle, by using a gray for the "off-lights" you reduce the contrast that the twinkling has. A state-change from black to white is better visible than a change from gray to white.

philipvr commented 2 years ago

I've decrease the brightness of the default state. But since I do want there to be some light to be emitted, I set the default state to be 10% brightness.