Relax restriction on scipy to be compatible with more recent numpy

stanford-crfm / levanter

Legible, Scalable, Reproducible Foundation Models with Named Tensors and Jax

https://levanter.readthedocs.io/en/latest/

Apache License 2.0

519 stars 82 forks source link

Relax restriction on scipy to be compatible with more recent numpy #796

Closed jennifgcrl closed 2 weeks ago

jennifgcrl commented 2 weeks ago

Correct me if I'm wrong but I think the <=1.12.0 bound on scipy is now vestigial? In any case, it's causing conflicts with other packages (e.g., most recent jax) that require a too new version of numpy for scipy to handle.

dlwh commented 2 weeks ago

Yep, definitely vestigial! There was like a week where JAX didn't work without the bound and I forgot to fix it! Probably we can just delete it since we don't use scipy directly

dlwh commented 2 weeks ago

Hi @jennifgcrl , thanks for raising this! I'm just gonna delete the dependency (in #797) instead, which should be at least as good. (If I'm wrong, let me know!)