stanford-esrg / retina

Retina is a network analysis framework that supports 100+ Gbps traffic analysis on a single server with no specialized hardware.
Apache License 2.0
147 stars 23 forks source link

Filter parsing for "or"'d filters #61

Closed thearossman closed 4 days ago

thearossman commented 1 month ago

Retina compilation fails if a user specifies a filter with multiple application-layer protocols that have different L4 encapsulation (e.g., "quic or tls").

The check for valid layering using the protocol graph is meant to validate encapsulation (e.g., prevent the user from specifying "quic AND tls"), but it also blocks valid "or" conditions. Ideally the check would be fixed so that the former behavior is kept while the latter is fixed.

thearossman commented 4 days ago

Fixed by multi-subscription