search

stanford-futuredata / gavel

Code for "Heterogenity-Aware Cluster Scheduling Policies for Deep Learning Workloads", which appeared at OSDI 2020
MIT License
125 stars 31 forks source link

The operation of shutil.rmtree #244

Closed JoeyYoung closed 1 year ago

JoeyYoung commented 1 year ago

Hi all,

Thanks for your excellent work. Just a small note when playing around with the framework, will you consider modifying the part of creating checkpoint_dir in line 73 of worker.py? I think the action of shutil.rmtree is dangerous and I almost deleted my whole workspace since I set the path outside the gavel directory (that's my fault of course) :(

deepakn94 commented 1 year ago

Can you create a PR? Happy to fix this behavior!