stanford-oval / genie-cloud

Genie As A Service and Thingpedia
https://genie.stanford.edu/
Apache License 2.0
295 stars 44 forks source link

Timezone issues when displaying time #1064

Open gcampax opened 3 years ago

gcampax commented 3 years ago

See log:

U: tell me a joke when i wake up
UT: $dialogue @org.thingpedia.dialogue.transaction.execute;
UT: attimer(time=[$time.morning]) => @com.icanhazdadjoke.get();
C: $dialogue @org.thingpedia.dialogue.transaction.execute;
C: ontimer(date=[$now + 10s]) => @org.thingpedia.media-player(id="com.spotify-gcampax"^^tt:device_id("Spotify Account of gcampax")).player_pause()
C: #[results=[
C:   { __device="com.spotify-gcampax"^^tt:device_id("Spotify Account of gcampax") }
C: ]];
C: attimer(time=[new Time(8, 30)]) => @com.icanhazdadjoke.get()
C: #[results=[]];
#! timestamp: 2021-08-03T19:30:05.528Z
A: What time does your morning begin?
A: Alright, I will get the joke every day at 1:30 AM.
AT: $dialogue @org.thingpedia.dialogue.transaction.sys_rule_enable_success;
#! vote: down

The time was parsed correctly to 8:30, but replied incorrectly to 1:30 AM.

I am not sure what time the program will actually run at.

gcampax commented 3 years ago

Notably, an alert set on a relative time ("5 minutes from now") displayed the correct time: image

gcampax commented 3 years ago

Another log related to that:

U: set a timer at 12:35pm
UT: $dialogue @org.thingpedia.dialogue.transaction.execute;
UT: ontimer(date=[set_time($now, new Time(12, 35))]) => @org.thingpedia.builtin.thingengine.builtin.alert();
C: $dialogue @org.thingpedia.dialogue.transaction.execute;
C: ontimer(date=[set_time($now, new Time(12, 35))]) => @org.thingpedia.builtin.thingengine.builtin.alert()
C: #[results=[]];
#! timestamp: 2021-08-03T19:34:57.285Z
A: Alright, I will alert at set time 5:35 AM on date now.
AT: $dialogue @org.thingpedia.dialogue.transaction.sys_rule_enable_success;