stanford-oval / thingpedia-common-devices

Thingpedia interface code for commonly used devices
Other
38 stars 28 forks source link

New skill: soccer #319

Closed arthbohra closed 3 years ago

gcampax commented 3 years ago

Hi Arth! This might be your first pull request to an open-source repository, so a few things you might want to keep in mind:

I'm going to go ahead and close the other PRs. If you want to reuse this one, the branch name that was chosen by github is "patch-2". Hence, you can continue working on this repo if you clone your work, checkout that branch, and then push to it. You can do an interactive rebase (git rebase -i) to repackage the commits, clean the history, and rewrite the commit messages. Also, by convention, we prefix all feature branches with "wip/" (see the other PRs in this repo for examples), but that's less important for a fork.

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts when merging c8352801fd28b6735afc32ef46cd36b94b8ce0e1 into e11c9859d3a957b1194f2a4634151a54c8ac5f34 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 68c3f7de34321aba0c1d43ae4c2f6adca3a67b82 into 23b3ef6cd34dcab41e3e241accee7a4f79a59061 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging acb6642cb4ef6c2acac40dfdc0902c68f820d158 into 99715b78be144be758b43f54b3f3c996a166c516 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging df5ff3a4504c46c2dd6f685f4f742f66e2265c23 into 99715b78be144be758b43f54b3f3c996a166c516 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 27a186bbc8ee1458c5bf1514957221d6042f5e69 into 99715b78be144be758b43f54b3f3c996a166c516 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts when merging 35b8fdc609fdbc2704045c5bc23b8bf9d64d582c into b903b80a5e53eac831030e31bf2898656311658a - view on LGTM.com

new alerts:

gcampax commented 3 years ago

Actually, my comment about canonical forms is pretty important - without it, we won't be generating any good training data. You need to write all the different ways to refer to each output parameter. Look at other skills in this repository like Spotify or Yelp for examples, you'll see there are lot of phrases for each parameter, in all different grammatical forms.

lgtm-com[bot] commented 3 years ago

This pull request introduces 6 alerts when merging 058ce8adfa62304f55f32e352e1891ea12080014 into 0ed1d35d680dfe87451e4894c5afc1e06765c857 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 6 alerts when merging af7f148a2ba2ff81de04b83c0558df32de37de83 into 0ed1d35d680dfe87451e4894c5afc1e06765c857 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging c2e3cce9918733c95b898965fea5314bb729e2ef into 0ed1d35d680dfe87451e4894c5afc1e06765c857 - view on LGTM.com

new alerts:

gcampax commented 3 years ago

Merged by #354