coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 1247
- 78 of 102 (76.47%) changed or added relevant lines in 1 file are covered.
- 3 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.8%) to 53.631%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| universe/org.themoviedb/index.js | 78 | 102 | 76.47% | ||
| <!-- | Total: | 78 | 102 | 76.47% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| universe/com.goal_smart/device.js | 1 | 95.34% | ||
| main/com.spotify/index.js | 2 | 60.2% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 1236: | 0.8% |
| Covered Lines: | 1156 |
| Relevant Lines: | 2047 |
@vik135 this is your PR, repackaged and ready for inclusion.
I made the following changes:
@org.themoviedbThe new scenario tests highlight that the skill doesn't quite do what the user most likely want, so you should work on that. You also need some annotated validation data to go into dev/annotated.txt otherwise we won't know if the model for this skill works or not. The Snips NLU benchmark contains some questions about movies (among other things) that would be a good starting point. You should take a look at their data, filter only the questions about movies, and then convert them to our format.