add dataset entries for adding songs to playlists

stanford-oval / thingpedia-common-devices

Thingpedia interface code for commonly used devices

Other

38 stars 28 forks source link

add dataset entries for adding songs to playlists #409

Closed ryachen01 closed 3 years ago

ryachen01 commented 3 years ago

The problem in issue #406 is that "add song to playlist" is being translated to @org.thingpedia.media-source().song() => @com.spotify.add_song_to_playlist(playlist="playlist", song=id); instead of @org.thingpedia.media-source(). get_currently_playing() => @com.spotify.add_song_to_playlist(playlist="playlist", song=id);

ryachen01 commented 3 years ago

Latest commit should also address issue #382

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1391

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 61.355%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
main/com.spotify/index.js	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
universe/com.goal_smart/device.js	1	94.85%
<!--	Total:	1		-->

Totals
Change from base Build 1384:	0.1%
Covered Lines:	1379
Relevant Lines:	2129

💛 - Coveralls

gcampax commented 3 years ago

Let's merge this

nrser commented 3 years ago

@gcampax does this require training a new model?

gcampax commented 3 years ago

The fix for stop doesn't (just need to run scripts/upload-all.sh to upload the new skill), the other fix ar the beginning does