search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.64k stars 215 forks source link

Feature: Add CircleCI and CodeCov #202

Closed angeldroth closed 3 years ago

angeldroth commented 3 years ago

More robust testing framework (Repo owners will need to sign up to free tier etc)

angeldroth commented 3 years ago

@mzjp2 obvs override anything I do here, your xp in this area is infinitely greater than mine haha

mzjp2 commented 3 years ago

By the way, any specific reason for CCI v/s GH Actions? I see GH actions are kinda already used here and this repo integrates with GH pages - might make sense to stay within the GH ecosystem? (just a random thought)

alejandroschuler commented 3 years ago

@mzjp2 yes, that was my original thought when I set up GH actions. Unless there are very specific things that GH doesn't provide I'd like to stick with it since it seems simpler. Open to different opinions, though- as I've said, I'm not a software engineer and I'll do anything to avoid being one :P

angeldroth commented 3 years ago

Both fair points, I've just gotten used to CCI and it's expanded set of features, but GHA might be better here for simplicity. Feel free to close PR if not needed :)

mzjp2 commented 3 years ago

I've overhauled the workflow for this library in https://github.com/stanfordmlgroup/ngboost/pull/204 @angeldroth - but done nothing about code coverage. If that gets accepted, then maybe you can build on top of that to add codecov (or even pytest-cov tbh)