search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.64k stars 215 forks source link

Possibly mistaken version of tqdm in requirements #208

Closed synapticarbors closed 3 years ago

synapticarbors commented 3 years ago

I was fixing up the conda-forge recipe for ngboost and noticed that during the switch to poetry, the minimum version of tqdm was changed from >=4.36.1 to >=4.3. The latter version of tqdm has no official release, but 4.4 was released in April of 2016. I'm wondering if the intended change was just to >=4.36?

alejandroschuler commented 3 years ago

@ryan-wolbeck @mzjp2

mzjp2 commented 3 years ago

This is a typo on my side, indeed. I was trying to tidy up version bounds and must have missed the 6 in4.36. Is this a big deal, or would it just resolve to a correct version anyway, right?

I guess it should he >=4.4 (as opposed to >=4.36 which feels unnecessarily restrictive, since other libraries might have different versions of tqdm specified)?

Or do we depend on specific functionality of tqdm>=4.36?

ryan-wolbeck commented 3 years ago

tqdm just creates a progress bar so I don't think we are tied to the functionality of 4.36 so I'm thinking we should just change it it to >= 4.4 since the current version is 4.51

synapticarbors commented 3 years ago

That's fine. I just wanted to make sure that there weren't any compatibility issues dropping to the much older version.

https://tqdm.github.io/releases/

If there aren't any important api changes between 4.4 and 4.36, then I that's fine.