Closed synapticarbors closed 3 years ago
@ryan-wolbeck @mzjp2
This is a typo on my side, indeed. I was trying to tidy up version bounds and must have missed the 6 in4.36
. Is this a big deal, or would it just resolve to a correct version anyway, right?
I guess it should he >=4.4
(as opposed to >=4.36
which feels unnecessarily restrictive, since other libraries might have different versions of tqdm
specified)?
Or do we depend on specific functionality of tqdm>=4.36
?
tqdm just creates a progress bar so I don't think we are tied to the functionality of 4.36 so I'm thinking we should just change it it to >= 4.4 since the current version is 4.51
That's fine. I just wanted to make sure that there weren't any compatibility issues dropping to the much older version.
https://tqdm.github.io/releases/
If there aren't any important api changes between 4.4 and 4.36, then I that's fine.
I was fixing up the conda-forge recipe for
ngboost
and noticed that during the switch topoetry
, the minimum version oftqdm
was changed from>=4.36.1
to>=4.3
. The latter version oftqdm
has no official release, but 4.4 was released in April of 2016. I'm wondering if the intended change was just to>=4.36
?