search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.64k stars 215 forks source link

Add gamma distribution #222

Closed z-feldman closed 3 years ago

z-feldman commented 3 years ago

Gamma distribution and log score

Kind of new to Python so definitely need it to be double checked. Did some testing and it's looked good so far.

ryan-wolbeck commented 3 years ago

@z-feldman can you triage the build errors for this PR. You can see them by clicking the details next to the failed builds like 

************* Module ngboost.distns.gamma
ngboost/distns/gamma.py:26:4: W0231: __init__ method from base class 'RegressionDistn' is not called (super-init-not-called)

-----------------------------------
Your code has been rated at 9.98/10

pylint on tests*.........................................................Passed
make: *** [Makefile:12: lint] Error 1
Error: Process completed with exit code 2.
z-feldman commented 3 years ago

I actually ended up finding an error when using a different dataset. I'm a little swamped so going to close this for now and will hopefully be able to come back to it soon and fix it