search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.64k stars 215 forks source link

Setup tox to enable testing with multiple python versions locally #230

Closed zyxue closed 3 years ago

zyxue commented 3 years ago

for testing against multiple python versions locally

more info about tox is available at https://tox.readthedocs.io/en/latest/

ryan-wolbeck commented 3 years ago

@zyxue can you provide context on the value prop with tox?

zyxue commented 3 years ago

otherwise, what's the recommended way to run tests locally for multiple versions of python?

zyxue commented 3 years ago

for example, I was trying to make sure

try:
    from importlib.metadata import version
except ImportError:
    # before python 3.8
    from importlib_metadata import version

works for all python versions locally in https://github.com/stanfordmlgroup/ngboost/pull/229/

ryan-wolbeck commented 3 years ago

@zyxue I'm not saying there is a better way I'm hoping you can explain the importance of using TOX generally so people understand the need for this PR

zyxue commented 3 years ago

I see. I've updated the title to make the purpose of using tox more explicit.