search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.63k stars 214 forks source link

Future Warning when running the examples #254

Closed JoseLlorensRipolles closed 3 years ago

JoseLlorensRipolles commented 3 years ago

Hi,

This package looks amazing, thank you!

When you run the examples, a future warning is raised concerning how the toy datasets are loaded from sklean:

venv/lib/python3.9/site-packages/sklearn/utils/validation.py:67: FutureWarning: Pass return_X_y=True as keyword args. From version 0.25 passing these as positional arguments will result in an error warnings.warn("Pass {} as keyword args. From version 0.25 "

As the warning suggest, going from X, Y = load_boston(True) to X, Y = load_boston(return_X_y=True) fix the warning and avoid the future error. This issue raises a few times in code and docs, so I thought I would just notify it rather than pushing a PR in case you don't want to change it.

Thank you in advance!

alejandroschuler commented 3 years ago

Thanks for the heads up! Do feel free to submit a PR, otherwise we'll get around to it one day :)