search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.63k stars 214 forks source link

Bump supported python version #285

Closed robertsont closed 2 years ago

robertsont commented 2 years ago

Hi All,

NGBoost currently supports python version 3.6.0 per this line. Pandas versions 1.0.0 and upwards, however, require at least python 3.6.1 or higher (see here). Supporting python 3.6.0 specifically is forcing the project to use a version of Pandas that is about two and a half years old. I'm actually having trouble running poetry install locally on Ubuntu 18.04.6 with python 3.9.1 due to (seemingly) the poetry dependency solver not correctly identifying the necessary version of numpy to build with this older version of pandas.

I propose increasing the minimum supported python version to 3.6.1 and would be happy to submit a PR accomplishing this, provided there's no problem with abandoning support for python 3.6.0.

alejandroschuler commented 2 years ago

A PR would be great! I don't think there's any reason not to bump the python version- @ryan-wolbeck does that sound right?

ryan-wolbeck commented 2 years ago

@alejandroschuler yeah I think it's worth bumping here, I'm having the same issue as @robertsont when trying to build from 3.9. Thanks for the contribution @robertsont!