search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.62k stars 214 forks source link

Remove declared pandas dependency #318

Closed jack-mcivor closed 10 months ago

jack-mcivor commented 1 year ago

Pandas is not required at run-time nor during development. It is required to run the example notebooks, but these seem to have separately tracked requirements here and here.

Note that lifelines (used in ngboost.evaluation) does require pandas, so ngboost still requires it transitively. Lifelines has a less stringent pandas requirement than what's currently provided.

jack-mcivor commented 10 months ago

Is it possible to get another review here please @ryan-wolbeck ?

ryan-wolbeck commented 10 months ago

After investigation of similar tools I think this makes sense. We could add this as a "dev" dependency but I don't that's probably necessary given the inherited dependency. @jack-mcivor can you re-trigger the pipeline tests/checks? (timed out)