search

stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.64k stars 215 forks source link

Update load_boston in README.md #340

Closed jyx-su closed 10 months ago

jyx-su commented 11 months ago

Fixed #339

jyx-su commented 11 months ago

Done @ryan-wolbeck

jyx-su commented 11 months ago

Removed the pandas dependency and ran "black ." Can you advise on why the tests still failed?

ryan-wolbeck commented 11 months ago

the order of your imports is in the incorrect style

isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /home/runner/work/ngboost/ngboost/examples/regression.py
Fixing /home/runner/work/ngboost/ngboost/examples/survival.py

If you have make and poetry installed in your environment you can just run make lint and it will run black and fix the import issues then you can make another commit

make lint run's the following poetry run pre-commit run --hook-stage manual --all-files