stanfordmlgroup / ngboost

Natural Gradient Boosting for Probabilistic Prediction
Apache License 2.0
1.62k stars 214 forks source link

Add support for python 3.12, drop python 3.8 #346

Closed connortann closed 4 months ago

connortann commented 5 months ago

Summary

Closes #345

Discussion

It was seemingly necessary to drop support for python 3.8 to enable poetry to allow numpy 1.26. If 3.8 support is retained, poetry only allows numpy up to 1.24 which has a bug on python 3.12: https://github.com/numpy/numpy/issues/23808

According to SPEC 0 (which superseded NEP29), python 3.8 is overdue to be dropped:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)