stanfordnlp / CoreNLP

CoreNLP: A Java suite of core NLP tools for tokenization, sentence segmentation, NER, parsing, coreference, sentiment analysis, etc.
http://stanfordnlp.github.io/CoreNLP/
GNU General Public License v3.0
9.72k stars 2.7k forks source link

Some enhanced++ UD edges missing in online demo #236

Closed nschneid closed 8 years ago

nschneid commented 8 years ago

I've been noticing that the online demo isn't finding some of the enhanced++ dependencies described in the LREC 2016 paper, such as nsubj:xsubj in "Sue wants to buy a hat", the nsubj in "the boy who lived", the second amod in "the long and wide river", and the copy node/edges in "She flew to Bali or to Turkey". Is this just a problem with the rendering on the demo page, or are these not being produced?

sebschu commented 8 years ago

This seems to be a problem with the rendering on the demo page. When I run CoreNLP locally, I get all the expected edges. We'll look into it.

(And thanks for reporting all these issues, btw.)

sebschu commented 8 years ago

Seems to be working now.

nschneid commented 8 years ago

I'm still getting the old behavior.

sebschu commented 8 years ago

Oh, it seems to have something to do with OpenIE. If you remove the OpenIE annotator, then it seems to work (which is obviously a bug).

sebschu commented 8 years ago

Now it seems to be working again for real but let me know if some edges are still missing.

nschneid commented 8 years ago

It's still not showing a copy node in "She flew to Bali or to Turkey". The other examples look good.

sebschu commented 8 years ago

Sorry for the late reply, but yes, the demo does not show copy nodes explicitly. However, the self-loops always indicate that there is a copy node! This has always been the case and I don't think that we are going to change that as brat doesn't allow us to visualize copy nodes in a good way and we are not planning on developing our own visualization tools.