search

stanfordnlp / CoreNLP

CoreNLP: A Java suite of core NLP tools for tokenization, sentence segmentation, NER, parsing, coreference, sentiment analysis, etc.
http://stanfordnlp.github.io/CoreNLP/
GNU General Public License v3.0
9.71k stars 2.7k forks source link

Custom features in NER package should use dependency injection #6

Open mcalpin opened 11 years ago

mcalpin commented 11 years ago

To add a custom feature extractor to the NER package, the path of least resistance is to modify NERFeatureFactory.java, AnnotationLookup.java, CoreAnnotations.java and SeqClassifierFlags.java. A more generic approach would use dependency injection, so third-party developers wouldn't have to touch code inside CoreNLP. If it's not already on your development roadmap, I'm happy to take on that change.

Dave

AngledLuffa commented 11 years ago

That's not on our radar, but we'd be happy to look at a proposed change,

John

On Sun, Nov 17, 2013 at 1:21 PM, mcalpin notifications@github.com wrote:

To add a custom feature extractor to the NER package, the path of least resistance is to modify NERFeatureFactory.java, AnnotationLookup.java, CoreAnnotations.java and SeqClassifierFlags.java. A more generic approach would use dependency injection, so third-party developers wouldn't have to touch code inside CoreNLP. If it's not already on your development roadmap, I'm happy to take on that change.

Dave

— Reply to this email directly or view it on GitHubhttps://github.com/stanfordnlp/CoreNLP/issues/6 .