search

stanfordnlp / GloVe

Software in C and data files for the popular GloVe model for distributed word representations, a.k.a. word vectors or embeddings
Apache License 2.0
6.86k stars 1.51k forks source link

change to the correct filemode for opening a binary file for output #116

Closed hcyang closed 6 years ago

hcyang commented 6 years ago

A small step trying to move GloVe forward for correct I/O, especially on native Windows environment. A more comprehensive pull request (#12) has been standing for more than two years!

manning commented 6 years ago

I'm looking at GloVe for the first time in a while….

In principle, happy to try to merge in changes so things work smoothly on Windows, but I also don't actually have a Windows dev environment with which to test things, so that confirmation that things work or don't work would be helpful. At any rate, this is a clear, simple, can't do any harm change…. Thanks!