stanfordnlp / GloVe

Software in C and data files for the popular GloVe model for distributed word representations, a.k.a. word vectors or embeddings
Apache License 2.0
6.86k stars 1.51k forks source link

Fix - memory violations #160

Closed przemb closed 4 years ago

przemb commented 4 years ago

Changes:

Description: In each mentioned file, some part of memory is leaked. After the execution of each step (complete pipeline), the final effect is massive memory leak.

Please compare logs generated by Valgrind.

Original - summary report: https://gist.github.com/przemb/1d23a21e2e8305cfe4014274e130446c Fixed - summary report: https://gist.github.com/przemb/d9166423bb2de3993a81acd460f866e5

I am also adding links to complete logs: Original - complete report: https://gist.github.com/przemb/a1c060adf0b922238bfe246688307d38 Fixed - complete report: https://gist.github.com/przemb/028d622f8a25eacc1c45869a4aff407d

Resolves #158 In case of any questions or suggestions related to my changes, please let me know :)

AngledLuffa commented 4 years ago

Mind squashing this into a single change (and handling the conflict that now exists)?

AngledLuffa commented 4 years ago

I resolved the conflicts myself. Thanks so much for fixing this! I'll take a look at the next one tomorrow.

przemb commented 4 years ago

Great, thanks :)