Repeating code moved to common.c/.h

stanfordnlp / GloVe

Software in C and data files for the popular GloVe model for distributed word representations, a.k.a. word vectors or embeddings

Apache License 2.0

6.86k stars 1.51k forks source link

Repeating code moved to common.c/.h #161

Closed przemb closed 4 years ago

przemb commented 4 years ago

As suggested in https://github.com/stanfordnlp/GloVe/pull/160 I added new files to resolve the problem of code repetition.

Changes:

new files added - common.h / common.c
makefile updated
minor changes (members renamed) - to separate HASHREC structure, which was nearly the same
redundant includes removed

AngledLuffa commented 4 years ago

Thanks! Are you interested in rebasing this to incorporate the other changes (and your other branch, which is now merged)? That's also something I can do.

AngledLuffa commented 4 years ago

I made the header changes and merged it. Thanks for the help!