search

stanfordnlp / GloVe

Software in C and data files for the popular GloVe model for distributed word representations, a.k.a. word vectors or embeddings
Apache License 2.0
6.81k stars 1.51k forks source link

URL with GloVe dataset not working #174

Open Nayef211 opened 4 years ago

Nayef211 commented 4 years ago
AngledLuffa commented 4 years ago

Our cluster is currently down for maintenance. It should be back within a day.

zhangguanheng66 commented 4 years ago

We have disabled our tests again due to the URL issue. https://github.com/pytorch/text/pull/888

AngledLuffa commented 4 years ago

I'm a little confused by that comment, because aren't those tests downloading mock zip files instead of the original zip files on nlp.stanford.edu?

Regardless, the nlp.stanford.edu url is working again.

Nayef211 commented 4 years ago

Disabled tests again due to URL breakage https://github.com/pytorch/text/pull/920.

To answer your question @AngledLuffa, we are using mock zip files for our tests, however, the filename is found by getting the headers from a HTTP GET call. You can refer to this code snippet for more info.

AngledLuffa commented 4 years ago

Can I recommend mocking that as well, then? Because our hardware occasionally has problems, and while we obviously want to fix it as quickly as possible, we also don't want to be responsible for your unit tests not working.

zhangguanheng66 commented 4 years ago

Can I recommend mocking that as well, then? Because our hardware occasionally has problems, and while we obviously want to fix it as quickly as possible, we also don't want to be responsible for your unit tests not working.

Yeap. That's what we are planning to do. But we probably won't moch the entire datasets because we don't want to host the datasets for legal issue.