stanfordnlp / cocoa

Framework for learning dialogue agents in a two-player game setting.
MIT License
158 stars 62 forks source link

Scenario generation #12

Closed hhexiy closed 8 years ago

hhexiy commented 8 years ago

Major changes:

hhexiy commented 8 years ago

Moved alphas to schema and addressed other comments too. Btw, shall we move generate_*.py (currently in src/basic) to scripts?

anushabala commented 8 years ago

LGTM! Moving the generate_* scripts to src/basic/scripts/ (I'm assuming that's what you meant?) makes sense - I think in general we should try to group scripts in src/basic into submodules of src/basic as far as possible!

percyliang commented 8 years ago

Moving to scripts sounds good. If we plan to have lots of scripts, then splitting by module makes sense, but src/scripts would make things easier to find. Don't have a strong opinion here.

LGTM

hhexiy commented 8 years ago

I think @anushabala might have other scripts for the website? If so, src/basic/scripts seems better.

anushabala commented 8 years ago

I was actually going to put the web scripts in src/web! So src/scripts is fine I think.

On Monday, October 3, 2016, hhexiy notifications@github.com wrote:

I think @anushabala https://github.com/anushabala might have other scripts for the website? If so, src/basic/scripts seems better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stanfordnlp/game-dialogue/pull/12#issuecomment-251190956, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLcv73Xo2atFGTmHI8y1lbAsbCNNpNMks5qwU2RgaJpZM4KL7sB .