search

stanfordnlp / cocoa

Framework for learning dialogue agents in a two-player game setting.
MIT License
158 stars 62 forks source link

Scoping issues in template #46

Closed skrcode closed 4 years ago

skrcode commented 6 years ago

https://github.com/stanfordnlp/cocoa/blob/65d61c714f0bc4a9bf24ad84ad6fc2105f0028bc/src/web/templates/chat.html#L335

This loop iter update does not seem to work, I guess due to scoping issues. A better alternative would be to remove the iterators and use the default {{loop.index}}, as suggested in https://stackoverflow.com/a/7537466

hhexiy commented 4 years ago

Thanks for the suggestion! It looks like this line is deprecate code and takes no effect now. So I'm closing this.