Closed jerryjliu closed 3 months ago
Thank you Jerry. We should merge this, but we're failing on Ruff checks, so that's the only thing we gotta resolve.
Thanks @jerryjliu for this PR! I patched the ruff fix directly.
left a minor comment for a typo and also just wanted to confirm if the PR was ready to merge from your end since there were some in-line TODOs.
will merge once you're ready!
ah so with the updated imports, this is failing the tests since llama_index is not a supported dependency. The llama_index import statements need to be wrapped in a try/except block to avoid triggering the errors like done here or moving it within the various initialization methods where the imports are needed as done here.
I can take a look at this soon to resolve this locally as well.
[update - feel free to disregard above. llamaindex needs to be a required dependency to import all its functions but updating poetry.lock within this PR breaks local DSPy tests. integration for libraries to avoid this import patch will be added via comprehensive integration tests in upcoming PRs!]
Thanks again @jerryjliu ! Exciting integration!
woot oops sorry just seeing this. @arnavsinghvi11 thanks for landing!!!
(btw feel free to DM me your twitter/linkedin handles, would be happy to promote on socials when this goes out)
add integrations + a full cookbook showing llamaindex + dspy: