stanfordnlp / python-stanford-corenlp

Python interface to CoreNLP using a bidirectional server-client interface.
MIT License
516 stars 105 forks source link

Add docDate support to annotate & update #28

Closed greasystrangler closed 5 years ago

greasystrangler commented 5 years ago

This change adds a "date" parameter to annotate and update which causes the server to set the reference date for the document being annotated.

greasystrangler commented 5 years ago

I added this because there seem to be some issues at present 3.9.1 and 3.9.2 with setting document date via properties (ner.docdate is the new property since 3.9.2 but it seems broken at present).

This change allows you to get properly populate timex values for TIME/DATE NERs.

arunchaganty commented 5 years ago

Thanks for the changes!

yuhaozhang commented 5 years ago

This change seems to be useful but gets lost during the migration from this library to the new stanfordnlp library. @greasystrangler, if possible, do you mind making a pull request to the new repo and adding this functionality?