stanfordnlp / pyvene

Stanford NLP Python Library for Understanding and Improving PyTorch Models via Interventions
http://pyvene.ai
Apache License 2.0
609 stars 59 forks source link

Make self.embed_dim not None. #49

Closed ZhengPeterWang closed 8 months ago

ZhengPeterWang commented 8 months ago

In line 265, there is a torch.arange(0, self.embed_dim). That will throw an error if self.embed_dim is None.

frankaging commented 8 months ago

good catch! thanks!