stanfordnlp / pyvene

Stanford NLP Python Library for Understanding and Improving PyTorch Models via Interventions
http://pyvene.ai
Apache License 2.0
559 stars 50 forks source link

[P0] remove autograd debugging #98

Closed aryamanarora closed 5 months ago

aryamanarora commented 5 months ago

Description

There was an autograd debugging line left in that significantly impacted performance. Discovered it while using a profiler to debug experiment speeds. Removing it reduced runtime for training my DAS benchmark work on pythia-14m from 289s to 170s!

Testing Done

No effect on library behaviours at all, just removed torch.autograd.set_detect_anomaly(True).

Checklist:

frankaging commented 5 months ago

Thanks for catching this!