search

stanfordnlp / treelstm

Tree-structured Long Short-Term Memory networks (http://arxiv.org/abs/1503.00075)
GNU General Public License v2.0
875 stars 236 forks source link

Fixed an Error: ./scripts/download.py tries to download a non-existent file #3

Closed erickmiller closed 8 years ago

erickmiller commented 8 years ago

This looks like a really cool project! I'm testing it for potential use for my CS221 final project :)

The current version of download.py in the scripts folder tries to download: /data/glove.840B.300d.txt.gz Which does not exist. It appears this old .gz file has been antiquated and superseded by this file: /data/glove.840B.300d.zip.

I found and fixed the error in the python script, and changed the extraction method from gzip to the unzip() function, and have tested it locally and appears to work properly. Tried to push the changes but the repo didn't grant me permission to push the fix.

FYI if you grant me permission to push the changes, let me know and I will push the fix asap.
Thanks!
Erick

kaishengtai commented 8 years ago

Thanks for pointing out this bug. To contribute your fix, you should create a pull request: https://help.github.com/articles/creating-a-pull-request/.