search

stanfordnmbl / opencap-api

Apache License 2.0
5 stars 6 forks source link

calibration should not be `done` if only one camera #139

Closed antoinefalisse closed 7 months ago

antoinefalisse commented 9 months ago

See here: https://api.opencap.ai/sessions/2a5f8b56-079d-4896-aeb9-dc949688836c/ I did get the error message on the frontend, but I think an error should be thrown and the status should not be done.

Thoughts @suhlrich and @AlbertoCasasOrtiz

AlbertoCasasOrtiz commented 9 months ago

I agree, this would make things easier and save resources

suhlrich commented 9 months ago

so whenever the frontend encounters a 'wrong number of cameras error' (eg 1 camera or < nCalibratedCameras) should we error the trial immediately? We could check this before the frontend sends a stop request, and have a variable in the stop request to error the trial immediately.

AlbertoCasasOrtiz commented 7 months ago

This was solved when n_calibrated_cameras was done. Now instead of having status "done" and uploading a video, the status is "error", and an error message is appended to meta and show to user: "No videos uploaded. Ensure phones are connected and you have stable internet connection."